allow to load sibling calls #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmcgroul is it "all extrinsic calls" or "calls with the same parent call"? |
|
@belopash calls with the same parent |
|
@tmcgroul maybe it is better to introduce "extrinsicSubcalls"? This could potentially cover more cases |
belopash
reviewed
Jul 21, 2024
| @@ -219,6 +220,15 @@ export class Call { | |||
| this.#subcalls = calls | |||
| } | |||
|
|
|||
| get siblings(): Call[] { | |||
There was a problem hiding this comment.
this new field looks a bit unnatural. You already can achieve the same by using call.parentCall.subcalls
belopash
force-pushed
the
master
branch
2 times, most recently
from
cc23118 to
1f6a573
Compare
|
closing due to "some" open questions and revealing that the task isn't really necessary 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.